autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent failing test in
the current master tree.

The autobuild log of the failure is available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-14-1939/flakey.log

The failure seems to be in the "samba" suite, whose build logs are available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-14-1939/samba.stderr
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-14-1939/samba.stdout

The top commit at the time of the failure was:

commit d444221d67abc05dc9966dd7e0a37d30f9848953
Author: Joe Guo <***@catalyst.net.nz>
Date: Thu May 10 17:23:02 2018 +1200

traffic: improve add_short_packet by avoiding dict.get

dict.get is slower than [].
Avoid get to improve performance.

(For 3989418 calls, total time decease from 9.395 to 8.573)

Signed-off-by: Joe Guo <***@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <***@samba.org>
Reviewed-by: Garming Sam <***@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <***@samba.org>
Autobuild-Date(master): Mon May 14 05:38:06 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

[749(4046)/845 at 51m37s] samba.tests.blackbox.traffic_summary(ad_dc_ntvfs)
[750(4046)/845 at 51m37s] samba.tests.blackbox.smbcontrol(ad_dc_ntvfs:local)
[751(4048)/845 at 51m39s] samba.tests.blackbox.smbcontrol(promoted_dc:local)
[752(4050)/845 at 51m40s] samba4.ldap.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[753(4089)/845 at 51m51s] samba4.tokengroups.krb5.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[754(4099)/845 at 51m59s] samba4.tokengroups.ntlm.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[755(4108)/845 at 52m7s] samba4.sam.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[756(4125)/845 at 52m10s] samba4.user_account_control.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[757(4136)/845 at 52m23s] samba4.schemaInfo.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[758(4138)/845 at 52m26s] samba.tests.dsdb_schema_attributes(ad_dc_ntvfs:local)
[759(4143)/845 at 52m40s] samba4.urgent_replication.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[760(4151)/845 at 52m43s] samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[761(4175)/845 at 54m16s] samba4.ldap.match_rules.python(ad_dc_ntvfs)
[762(4209)/845 at 54m43s] samba4.ldap.notification.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[763(4212)/845 at 54m52s] samba4.ldap.sites.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[764(4223)/845 at 54m59s] samba4.ldap.sort.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[765(4230)/845 at 55m7s] samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[766(4245)/845 at 1h6m32s] samba4.ldap.linked_attributes.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[767(4265)/845 at 1h6m38s] samba4.ldap.rodc.python(rodc)(rodc)
[768(4271)/845 at 1h6m42s] samba4.ldap.rodc_rwdc.python(rodc)(rodc:local)
[769(4291)/845 at 1h13m55s] samba4.drs.replica_sync_rodc.python(rodc)(rodc:local)
[770(4293)/845 at 1h14m4s] samba4.ldap.password_settings.python(ad_dc_ntvfs)
[771(4303)/845 at 1h14m11s] samba4.ldap_schema.python(ad_dc_ntvfs)(ad_dc_ntvfs)
GSS client Update(krb5)(1) Update failed: Miscellaneous failure (see text): Clock skew too great
UNEXPECTED(error): samba4.ldap_schema.python(ad_dc_ntvfs).__main__.SchemaTests_msDS_IntId.test_msDS_IntId_on_class(ad_dc_ntvfs)
REASON: Exception: Exception: Traceback (most recent call last):
File "/memdisk/autobuild/fl/b3338408/samba/source4/dsdb/tests/python/ldap_schema.py", line 1529, in test_msDS_IntId_on_class
self._ldap_schemaUpdateNow()
File "/memdisk/autobuild/fl/b3338408/samba/source4/dsdb/tests/python/ldap_schema.py", line 1362, in _ldap_schemaUpdateNow
self.ldb.modify_ldif(ldif)
File "bin/python/samba/__init__.py", line 241, in modify_ldif
self.modify(msg, controls)
LdbError: (3, 'ldb_wait from (null) with LDB_WAIT_ALL: Time limit exceeded (3)')

FAILED (0 failures, 1 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
./bin/ab/summary
TOP 10 slowest tests
samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 684
samba4.ldap.rodc_rwdc.python(rodc)(rodc:local) -> 433
samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 227
samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 203
samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 137
samba4.raw.notify(ad_dc_ntvfs) -> 106
samba4.ldb.ldaps with options -U"$USERNAME%$PASSWORD"(ad_dc_ntvfs)(ad_dc_ntvfs) -> 100
samba4.rpc.samlogon on ncacn_np with (ad_dc_ntvfs) -> 99
samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 93
samba.tests.emulate.traffic_packet(ad_dc_ntvfs) -> 69
ERROR: test failed with exit code 1

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent failing test in
the current master tree.

The autobuild log of the failure is available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0137/flakey.log

The failure seems to be in the "samba" suite, whose build logs are available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0137/samba.stderr
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0137/samba.stdout

The top commit at the time of the failure was:

commit 5ebe3183fded1ab060ed60baeedeac859d0c137e
Author: Andrew Bartlett <***@samba.org>
Date: Tue May 15 12:26:03 2018 +1200

selftest: Make setexpiry test much more reliable

Rather than setting all the expiries and expecting that they will be done within 5 seconds,
measure and check the time individually for each record.

This should make this test much less prone to flapping.

Signed-off-by: Andrew Bartlett <***@samba.org>
Reviewed-by: Gary Lockyer <***@catalyst.net.nz>

Autobuild-User(master): Andrew Bartlett <***@samba.org>
Autobuild-Date(master): Tue May 15 23:58:17 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

[615(3425)/845 at 46m27s] samba4.rpc.echo against s4member server with local creds(s4member)
[616(3435)/845 at 46m30s] samba4.rpc.echo against s4member server with domain creds(s4member)
[617(3445)/845 at 46m33s] samba4.rpc.samr against s4member server with local creds(s4member)
[618(3445)/845 at 46m34s] samba4.rpc.samr.users against s4member server with local creds(s4member)
[619(3445)/845 at 46m37s] samba4.blackbox.smbclient against s4member server with local creds(s4member)
[620(3490)/845 at 46m40s] samba4.rpc.echo against rpc proxy with domain creds(rpc_proxy)
[621(3500)/845 at 46m43s] samba4.smb.signing on with -k no --signing=on(ad_dc_ntvfs)
[622(3501)/845 at 46m44s] samba4.smb.signing on with -k no --signing=required(ad_dc_ntvfs)
[623(3502)/845 at 46m44s] samba4.smb.signing on with -k no --option=clientusespnego=no --signing=on(ad_dc_ntvfs)
[624(3503)/845 at 46m44s] samba4.smb.signing on with -k no --option=clientusespnego=no --signing=required(ad_dc_ntvfs)
[625(3504)/845 at 46m44s] samba4.smb.signing on with -k no --option=gensec:spengo=no --signing=on(ad_dc_ntvfs)
[626(3505)/845 at 46m44s] samba4.smb.signing on with -k no --option=gensec:spengo=no --signing=required(ad_dc_ntvfs)
[627(3506)/845 at 46m44s] samba4.smb.signing on with -k yes --signing=on(ad_dc_ntvfs)
[628(3507)/845 at 46m45s] samba4.smb.signing on with -k yes --signing=required(ad_dc_ntvfs)
[629(3508)/845 at 46m45s] samba4.smb.signing on with -k yes --option=gensec:fake_gssapi_krb5=yes --option=gensec:gssapi_krb5=no --signing=on(ad_dc_ntvfs)
[630(3509)/845 at 46m45s] samba4.smb.signing on with -k yes --option=gensec:fake_gssapi_krb5=yes --option=gensec:gssapi_krb5=no --signing=required(ad_dc_ntvfs)
[631(3510)/845 at 46m45s] samba4.smb.signing disabled on with -k no --signing=off domain-creds(s4member)
[632(3511)/845 at 46m46s] samba4.smb.signing disabled on with -k no --option=clientusespnego=no --signing=off domain-creds(s4member)
[633(3512)/845 at 46m46s] samba4.smb.signing disabled on with -k no --option=gensec:spengo=no --signing=off domain-creds(s4member)
[634(3513)/845 at 46m46s] samba4.smb.signing disabled on with -k yes --signing=off domain-creds(s4member)
[635(3514)/845 at 46m46s] samba4.smb.signing on with -k no --signing=off local-creds(s4member)
[636(3515)/845 at 46m46s] samba4.smb.signing on with -k no --option=clientusespnego=no --signing=off local-creds(s4member)
[637(3516)/845 at 46m46s] samba4.smb.signing on with -k no --option=gensec:spengo=no --signing=off local-creds(s4member)
[638(3517)/845 at 46m47s] samba4.smb.signing --signing=yes anon(ad_dc_ntvfs)
[639(3518)/845 at 46m47s] samba4.smb.signing --signing=required anon(ad_dc_ntvfs)
[640(3519)/845 at 46m47s] samba4.smb.signing --signing=no anon(s4member)
[641(3520)/845 at 46m47s] samba4.winbind.struct(s4member:local)
Running WINBINDD_SHOW_SEQUENCE (struct based)
* BUILTIN : 1
* S4MEMBER : 1526427293
* SAMBADOMAIN : 8776
UNEXPECTED(failure): samba4.winbind.struct.show_sequence(s4member:local)
REASON: Exception: Exception: ../source4/torture/winbind/struct_based.c:808: WINBINDD_SHOW_SEQUENCE returned 0, expected 1

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
./bin/ab/summary
TOP 10 slowest tests
samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 225
samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 201
samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 156
samba4.ldb.ldaps with options -U"$USERNAME%$PASSWORD"(ad_dc_ntvfs)(ad_dc_ntvfs) -> 135
samba4.raw.notify(ad_dc_ntvfs) -> 107
samba4.rpc.samlogon on ncacn_np with (ad_dc_ntvfs) -> 83
samba4.ntvfs.cifs.krb5.base.deny2(ad_dc_ntvfs) -> 57
samba4.base.deny2(ad_dc_ntvfs) -> 57
samba4.nbt.winsreplication(ad_dc_ntvfs) -> 56
samba4.ntvfs.cifs.krb5.base.deny1(ad_dc_ntvfs) -> 52
ERROR: test failed with exit code 1

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent failing test in
the current master tree.

The autobuild log of the failure is available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0636/flakey.log

The failure seems to be in the "samba-nt4" suite, whose build logs are available here:

https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0636/samba-nt4.stderr
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-16-0636/samba-nt4.stdout

The top commit at the time of the failure was:

commit c7a3ce95ac4ce837d8fde36578b3b1f56c3ac2fa
Author: Stefan Metzmacher <***@samba.org>
Date: Mon May 7 14:50:27 2018 +0200

auth/ntlmssp: fix handling of GENSEC_FEATURE_LDAP_STYLE as a server

This fixes "NTLMSSP NTLM2 packet check failed due to invalid signature!"
error messages, which were generated if the client only sends
NTLMSSP_NEGOTIATE_SIGN without NTLMSSP_NEGOTIATE_SEAL on an LDAP
connection.

This fixes a regession in the combination of commits
77adac8c3cd2f7419894d18db735782c9646a202 and
3a0b835408a6efa339e8b34333906bfe3aacd6e3.

We need to evaluate GENSEC_FEATURE_LDAP_STYLE at the end
of the authentication (as a server, while we already
do so at the beginning as a client).

As a reminder I introduced GENSEC_FEATURE_LDAP_STYLE
(as an internal flag) in order to let us work as a
Windows using NTLMSSP for LDAP. Even if only signing is
negotiated during the authentication the following PDUs
will still be encrypted if NTLMSSP is used. This is exactly the
same as if the client would have negotiated NTLMSSP_NEGOTIATE_SEAL.
I guess it's a bug in Windows, but we have to reimplement that
bug. Note this only applies to NTLMSSP and only to LDAP!
Signing only works fine for LDAP with Kerberos
or DCERPC and NTLMSSP.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13427

Signed-off-by: Stefan Metzmacher <***@samba.org>
Reviewed-by: Andrew Bartlett <***@samba.org>

Autobuild-User(master): Andrew Bartlett <***@samba.org>
Autobuild-Date(master): Wed May 16 03:26:03 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

[453(2311)/500 at 18m6s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local)
[454(2312)/500 at 18m6s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local)
[455(2313)/500 at 18m7s] samba.wbinfo_simple.change-secret.domain=$DOMAIN(nt4_dc:local)
[456(2314)/500 at 18m7s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_dc:local)
[457(2315)/500 at 18m7s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_dc:local)
[458(2316)/500 at 18m7s] samba.wbinfo_simple.domain-users(nt4_dc:local)
[459(2317)/500 at 18m7s] samba.wbinfo_simple.domain-groups(nt4_dc:local)
[460(2318)/500 at 18m7s] samba.wbinfo_simple.name-to-sid=$DC_USERNAME(nt4_dc:local)
[461(2319)/500 at 18m7s] samba.wbinfo_simple.name-to-sid=$DOMAIN/$DC_USERNAME(nt4_dc:local)
[462(2320)/500 at 18m7s] samba.wbinfo_simple.user-info=$DOMAIN/$DC_USERNAME(nt4_dc:local)
[463(2321)/500 at 18m7s] samba.wbinfo_simple.user-groups=$DOMAIN/$DC_USERNAME(nt4_dc:local)
[464(2322)/500 at 18m7s] samba.wbinfo_simple.authenticate=$DOMAIN/$DC_USERNAME%$DC_PASSWORD(nt4_dc:local)
[465(2323)/500 at 18m7s] samba.wbinfo_simple.allocate-uid(nt4_dc:local)
[466(2324)/500 at 18m7s] samba.wbinfo_simple.allocate-gid(nt4_dc:local)
[467(2325)/500 at 18m8s] samba.wbinfo_sids2xids.(nt4_dc:local)(nt4_dc:local)
[468(2326)/500 at 18m14s] samba.ntlm_auth.diagnostics(nt4_dc:local)(nt4_dc:local)
[469(2327)/500 at 18m14s] samba.ntlm_auth.(nt4_dc:local)(nt4_dc:local)
[470(2346)/500 at 18m16s] samba.wbinfo_simple.ping(nt4_member:local)
[471(2347)/500 at 18m16s] samba.wbinfo_simple.separator(nt4_member:local)
[472(2348)/500 at 18m16s] samba.wbinfo_simple.own-domain(nt4_member:local)
[473(2349)/500 at 18m16s] samba.wbinfo_simple.all-domains(nt4_member:local)
[474(2350)/500 at 18m16s] samba.wbinfo_simple.trusted-domains(nt4_member:local)
[475(2351)/500 at 18m16s] samba.wbinfo_simple.domain-info=BUILTIN(nt4_member:local)
[476(2352)/500 at 18m16s] samba.wbinfo_simple.domain-info=$DOMAIN(nt4_member:local)
[477(2353)/500 at 18m16s] samba.wbinfo_simple.online-status(nt4_member:local)
[478(2354)/500 at 18m16s] samba.wbinfo_simple.online-status.domain=BUILTIN(nt4_member:local)
[479(2355)/500 at 18m17s] samba.wbinfo_simple.online-status.domain=$DOMAIN(nt4_member:local)
[480(2356)/500 at 18m17s] samba.wbinfo_simple.check-secret.domain=$DOMAIN(nt4_member:local)
UNEXPECTED(failure): samba.wbinfo_simple.check-secret.domain=SAMBA-TEST.wbinfo(nt4_member:local)
REASON: Exception: Exception: wbcCheckTrustCredentials(SAMBA-TEST): error code was NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND (0xc0000233)
failed to call wbcCheckTrustCredentials: WBC_ERR_AUTH_ERROR
Could not check secret
checking the trust secret for domain SAMBA-TEST via RPC calls failed

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
./bin/ab/summary
TOP 10 slowest tests
samba3.raw.notify(nt4_dc) -> 98
samba3.smb2.notify(nt4_dc) -> 80
samba3.rpc.samr.passwords.lockout(nt4_dc) -> 61
samba4.rpc.echo on ncacn_np with object(nt4_dc) -> 60
samba3.rpc.samr.passwords.pwdlastset(nt4_dc) -> 49
samba3.smb2.lease(nt4_dc) -> 45
samba3.raw.oplock(nt4_dc) -> 42
samba3.smb2.oplock(nt4_dc) -> 41
samba3.raw.search(nt4_dc) -> 34
samba3.raw.lock(nt4_dc) -> 33
ERROR: test failed with exit code 1